From 3707750246e4f89a8aaabd08402f501db3b56712 Mon Sep 17 00:00:00 2001 From: Bryan Black Date: Tue, 15 May 2018 10:20:13 -0700 Subject: [PATCH] fix for #7 Fix for https://github.com/stationgroup/ansible-experiments/issues/7 I think `freebsd-update` return failed even when _"No updates needed"_ or _"No update are available"_. https://github.com/freebsd/pkg/issues/1470 ``` failed_when: False # --dry-run always returns failure # https://github.com/freebsd/pkg/issues/1470 ``` --- package_updates/roles/freebsd-update/tasks/main.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package_updates/roles/freebsd-update/tasks/main.yml b/package_updates/roles/freebsd-update/tasks/main.yml index f395e48..a340cee 100644 --- a/package_updates/roles/freebsd-update/tasks/main.yml +++ b/package_updates/roles/freebsd-update/tasks/main.yml @@ -1,6 +1,8 @@ --- - name: Fetch any new FreeBSD updates command: freebsd-update fetch --not-running-from-cron + failed_when: False # --dry-run always returns failure + # https://github.com/freebsd/pkg/issues/1470 check_mode: no when: ansible_distribution == 'FreeBSD' register: result_update @@ -11,6 +13,8 @@ - name: Install FreeBSD updates command: freebsd-update install --not-running-from-cron + failed_when: False # --dry-run always returns failure + # https://github.com/freebsd/pkg/issues/1470 when: ansible_distribution == 'FreeBSD' and result_update.changed and not ansible_check_mode register: result_update_install changed_when: "'No updates are available to install' not in result_update_install.stdout"